Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for EF db seeder #4456

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Initial commit for EF db seeder #4456

wants to merge 6 commits into from

Conversation

rkac-bw
Copy link
Contributor

@rkac-bw rkac-bw commented Jul 3, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-5985

📔 Objective

Use EF to create CLI for seeding databases for the specific provider

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.31%. Comparing base (ef44def) to head (82201c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4456      +/-   ##
==========================================
- Coverage   41.31%   41.31%   -0.01%     
==========================================
  Files        1262     1262              
  Lines       60061    60067       +6     
  Branches     5483     5484       +1     
==========================================
  Hits        24816    24816              
- Misses      34102    34108       +6     
  Partials     1143     1143              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Logo
Checkmarx One – Scan Summary & Details185336c5-4733-4dd7-85db-92e7cc254ec1

No New Or Fixed Issues Found

@withinfocus withinfocus requested a review from MGibson1 July 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant