-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2820] Updated org edit form scripts to dynamically update expected values #4439
[AC-2820] Updated org edit form scripts to dynamically update expected values #4439
Conversation
736ebff
to
de0e1c7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4439 +/- ##
==========================================
- Coverage 41.65% 41.61% -0.04%
==========================================
Files 1276 1276
Lines 60302 60358 +56
Branches 5543 5544 +1
==========================================
Hits 25118 25118
- Misses 34013 34069 +56
Partials 1171 1171 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
…tting of seats since it's not a valid edge case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-2820
📔 Objective
This PR addresses an issue where organizations created via the Bitwarden Portal for a Reseller Provider were being set to have a
MaxStorageGb
of0
instead of the default1
. When investigating this issue, I found the same was true when settingModel.Seats
, so I addressed this as well.Instead of hardcoding these values as seen with the other form fields being set, I updated the function not to use a switch-case approach on the plan type and setting hard-coded values, but instead to get the selected plan type from the
StaticStore
, then set the relevant fields based on the default values on the given plan. Feel free to disagree with this approach if you prefer the former!📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes