-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-9361] Generate Swagger specs in CI for the SDK #4428
Conversation
d19f83b
to
2f66851
Compare
New Issues
|
2f66851
to
41cd239
Compare
41cd239
to
ac420e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4428 +/- ##
=======================================
Coverage 41.91% 41.91%
=======================================
Files 1288 1288
Lines 60921 60921
Branches 5597 5597
=======================================
Hits 25532 25532
Misses 34200 34200
Partials 1189 1189 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AC owned file change makes sense - thanks @dani-garcia !
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-9361
📔 Objective
Update the CI build script to also generate the swagger specs for the internal API and the identity API, which are used to generate the
bitwarden-api-*
crates for the SDK.While implementing this I noticed that the internal API specs were failing to generate with the following error:
I've marked
ValidateAdminRequest
as[NonAction]
so the spec generator doesn't try to parse this function as an action. Marking it asprivate
orprotected
would also work, but this function is also used in some tests.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes