Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts #88

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Update scripts #88

merged 1 commit into from
Dec 19, 2024

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Dec 18, 2024

🎟️ Tracking

📔 Objective

  • Unify all scripts to have set -eo pipefail, add shebangs and make sure that they can be run from any directories.
  • Allow Kotlin local builds to also build all the architectures optionally.
  • Fix sed command in memory_testing that broke when after the cargo-sort PR, where the order of the entries was changed. Thanks ChatGPT for the regex help hah

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details99af8d38-0b1d-4318-bb59-b7bee6e8a7fc

No New Or Fixed Issues Found

@dani-garcia dani-garcia marked this pull request as ready for review December 18, 2024 14:40
@dani-garcia dani-garcia requested a review from Hinton December 18, 2024 14:40
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (fe2b4f3) to head (7d022e9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   64.41%   64.41%           
=======================================
  Files         188      188           
  Lines       13819    13819           
=======================================
  Hits         8902     8902           
  Misses       4917     4917           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia merged commit f197d30 into main Dec 19, 2024
41 checks passed
@dani-garcia dani-garcia deleted the ps/update-scripts branch December 19, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants