Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route Passwordless API errors in PasswordlessService #84

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Route Passwordless API errors in PasswordlessService #84

merged 2 commits into from
Nov 28, 2023

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Nov 27, 2023 •
edited
Loading

https://bitwarden.atlassian.net/browse/PAS-260

Is this the direction we want to take?

abergs
abergs approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@abergs abergs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is the right way to go!

This way, when people use our AspNetCore SDK they in turn won't receive 500.

If we ever want a throwing behaviour instead we can add that to the options.

@Tyrrrz Tyrrrz merged commit f37c27b into main Nov 28, 2023
6 checks passed
@Tyrrrz Tyrrrz deleted the correct-status-code branch November 28, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs abergs approved these changes

@jonashendrickx jonashendrickx Awaiting requested review from jonashendrickx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyrrrz @abergs