Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify Slack on successful release deploy #52

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Notify Slack on successful release deploy #52

merged 2 commits into from
Oct 4, 2023

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Oct 4, 2023 •
edited
Loading

This sends a message in Slack on successful stable release deployment, with the following content:

Passwordless.NET new version released!
Version: 1.0.2
Details: https://github.com/passwordless/passwordless-dotnet/releases/tag/v1.0.2

@Tyrrrz Tyrrrz requested a review from abergs October 4, 2023 15:48
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Oct 4, 2023

@abergs mergeable on approval

abergs
abergs approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tyrrrz I'm guessing the URL will be masked since it comes from secret? I noticed in the action we do log it as info.

If so - approved

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Oct 4, 2023

@Tyrrrz I'm guessing the URL will be masked since it comes from secret? I noticed in the action we do log it as info.

Yes, secrets are automatically masked by GitHub Actions. Here's a screenshot from one of my own projects that uses this action for a similar purpose:

image

@Tyrrrz Tyrrrz merged commit 6bdb474 into main Oct 4, 2023
6 checks passed
@Tyrrrz Tyrrrz deleted the notify-on-deploy branch October 4, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs abergs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyrrrz @abergs