Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package metadata, sourcelink, inline docs, debug symbols, enable reproducible builds #32

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Add package metadata, sourcelink, inline docs, debug symbols, enable reproducible builds #32

merged 3 commits into from
Sep 21, 2023

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Sep 20, 2023

  • Added some extra package metadata
  • Enabled sourcelink (lets users of the library navigate directly to GitHub sources of various symbols)
  • Enabled inline documentation (we already have inline docs, we were just not publishing them)
  • Enabled embedded debug symbols (works better than publishing symbols separately)
  • Enabled reproducible builds (ensures same source always produces the same binary, scrubs non-deterministic info)

abergs
abergs approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@abergs abergs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! See comment

Directory.Build.props Show resolved Hide resolved
@Tyrrrz Tyrrrz merged commit 49c64a1 into main Sep 21, 2023
2 checks passed
@Tyrrrz Tyrrrz deleted the source-link-and-docs branch September 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs abergs approved these changes

@jonashendrickx jonashendrickx Awaiting requested review from jonashendrickx

@jrmccannon jrmccannon Awaiting requested review from jrmccannon

@justindbaur justindbaur Awaiting requested review from justindbaur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyrrrz @abergs