-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Version bumping #27
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Alt B is pretty much implemented via #49 in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work experimentation purposes only. Do not merge.
Alt A version bumping - a bit more complicated:
Have a version-workflow that automatically creates a branch/pr called "[Version Bump] 1.0.5"
Have it lock the PR, so only contributors can comment
Have it listen to comments on the PR, if someone comments "v1.1.0"
It commits to the branch, and bumps the version to 1.1.0
When merged, it automatically creates a new PR called "[Version Bump] 1.1.1"
Alt B version bumping - simpler:
Have a version-workflow that when manually triggered with input, creates a branch/pr called "[Version Bump] 1.0.5".
The PR could ideally be merged automatically.
Release:
Manually create a release, targeting a new tag of main (haven't figured out a great way to do auomatic tags yet)
Set version to match the tag.
On release creation, dotnet build, nuget push, etc
After release, run version-bump workflow to bump patch on main.
We went with Alternative B.