Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Version bumping #27

Closed
wants to merge 19 commits into from
Closed

WIP Version bumping #27

wants to merge 19 commits into from

Conversation

abergs
Copy link
Member

@abergs abergs commented Sep 20, 2023

This PR is work experimentation purposes only. Do not merge.

Alt A version bumping - a bit more complicated:
Have a version-workflow that automatically creates a branch/pr called "[Version Bump] 1.0.5"
Have it lock the PR, so only contributors can comment
Have it listen to comments on the PR, if someone comments "v1.1.0"
It commits to the branch, and bumps the version to 1.1.0
When merged, it automatically creates a new PR called "[Version Bump] 1.1.1"

Alt B version bumping - simpler:
Have a version-workflow that when manually triggered with input, creates a branch/pr called "[Version Bump] 1.0.5".
The PR could ideally be merged automatically.

Release:

Manually create a release, targeting a new tag of main (haven't figured out a great way to do auomatic tags yet)
Set version to match the tag.
On release creation, dotnet build, nuget push, etc
After release, run version-bump workflow to bump patch on main.

We went with Alternative B.

@Tyrrrz Tyrrrz mentioned this pull request Oct 2, 2023
@Tyrrrz
Copy link
Contributor

Tyrrrz commented Oct 2, 2023

Alt B is pretty much implemented via #49 in the bump workflow, I believe. Can this PR be closed or is there anything missing still?

@abergs abergs closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants