Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize projects #24

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Standardize projects #24

merged 6 commits into from
Sep 20, 2023

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Sep 19, 2023

Rename projects to match assembly names, clean up. Does not involve any breaking changes.

@Tyrrrz Tyrrrz added the enhancement New feature or request label Sep 19, 2023
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 19, 2023

A bit confused in regards to dotnet format errors, can't reproduce it locally. Can anyone help out?

Thanks @justindbaur!

.editorconfig Show resolved Hide resolved
Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Wondering if @justindbaur has any comments? Note that there's a small conflict.

@justindbaur
Copy link
Member

So this was born out of a practice I inherited from bitwarden/server. But I think there is sufficient reason that the pros I get from it in there aren't needed here.

There I like to just be able to do Ctrl+P type in Admin and see the .csproj file right there near the top and not have to constantly type through the prefix to have confidence it will be there at the type. But in this repo, there is a lot less going on AND it is more common to have things that are nuget packages, have the exact name in the csproj as the package id so it could be easier to find. So for that I think we should instead make the names Passwordless and Passwordless.Tests.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 20, 2023

...have the exact name in the csproj as the package id so it could be easier to find. So for that I think we should instead make the names Passwordless and Passwordless.Tests.

One thing to point out is that the package id and the assembly/namespace names are still going to be mismatched here because the package id is Passwordless while the latter two are Passwordless.Net. However, that reduces mismatches from 2 to 1 at least 🙂 The other issue is not possible to solve without a breaking change.

@abergs
Copy link
Member

abergs commented Sep 20, 2023

@Tyrrrz @justindbaur Breaking changes have way less impact now than in 6 months.

@justindbaur
Copy link
Member

@Tyrrrz Yeah I think that was a miscommunication between @abergs and I, I sorta expected the package id to be Passwordless.Net (following [Company].[Product] and being a little cheeky with the pronunciation). I think we should for sure make the package file name equal to the package id and I'm fine with changing the namespace but I leave that to you all.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 20, 2023

@abergs @justindbaur Makes sense. Should I change the namespace to just Passwordless then to match the package ID?

image

@abergs
Copy link
Member

abergs commented Sep 20, 2023

@Tyrrrz Yep!

I think that was a miscommunication between @abergs and I, I sorta expected the package id to be Passwordless.Net

Initially I thought that would be package name as well, but then Passwordless was available so I grabbed it. Seemed better :)

@Tyrrrz Tyrrrz merged commit 81f9146 into main Sep 20, 2023
2 checks passed
@Tyrrrz Tyrrrz deleted the rename-projects branch September 20, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants