Step up v2 #135
Merged
Step up v2 #135
+403
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks. Showing claims on hello world to show which claims the user has.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 60.40% 60.31% -0.10%
==========================================
Files 43 43
Lines 639 640 +1
Branches 55 55
==========================================
Hits 386 386
- Misses 248 249 +1
Partials 5 5 ☔ View full report in Codecov by Sentry. |
jonashendrickx
requested changes
Jun 23, 2024
tests/Passwordless.AspNetCore.Tests/OldTests/PasswordlessServiceTests.cs
Outdated
Show resolved
Hide resolved
examples/Passwordless.AspNetIdentity.Example/Authorization/StepUpAuthorizationHandler.cs
Outdated
Show resolved
Hide resolved
examples/Passwordless.AspNetIdentity.Example/Pages/Account/Recovery.cshtml.cs
Outdated
Show resolved
Hide resolved
jonashendrickx
approved these changes
Jun 27, 2024
|
|
||
| public class StepUpAuthorizationHandler(StepUpPurpose stepUpPurpose, TimeProvider timeProvider) : AuthorizationHandler<IStepUpAuthorizationRequirement> | ||
| { | ||
| protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, IStepUpAuthorizationRequirement requirement) |
There was a problem hiding this comment.
Might not be correct, usually you want a specific permission here that is required, and do the step up procedure separately to add the claim to your token which then validates afterwards if you have a specific claim I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add Purpose to the Verify User model to be used with sign in and step up. It also adds functionality to the sample app for step up, magic links, and manually generated tokens.