Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo tune-up #10

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Repo tune-up #10

merged 1 commit into from
Aug 1, 2024

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

Internal change.

📔 Objective

Adjusts some repo content per the latest template and best practices.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor Author

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can land this after the repo is public.


# DevOps for Actions and other workflow changes
.github/workflows @bitwarden/dept-devops
* @bitwarden/team-platform-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Or Architecture ...

"matchUpdateTypes": ["minor", "patch"]
},
{
"additionalBranchPrefix": "{{parentDir}}-",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Separate updates per folder.

Comment on lines +86 to +87
/d:sonar.test.inclusions=extensions/*/examples/,extensions/*/tests/ \
/d:sonar.exclusions=extensions/*/examples/,extensions/*/tests/ \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ The only unique part.

@withinfocus withinfocus marked this pull request as ready for review August 1, 2024 17:31
@withinfocus withinfocus requested review from a team as code owners August 1, 2024 17:31
@withinfocus withinfocus merged commit 5cd63a4 into main Aug 1, 2024
1 check passed
@withinfocus withinfocus deleted the tuneup branch August 1, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants