Revert ldapjs update, use forked repo instead #133
Conversation
| }, | ||
| "engines": { | ||
| "node": ">=0.8" | ||
| } | ||
| }, | ||
| "node_modules/ldap-filter/node_modules/assert-plus": { |
There was a problem hiding this comment.
@eliykat , it would seem while you can revert the change to package.json, there have been SOOOO many other updates that it would be better to only revert that file and instead npm i to regen only the necessary portions of package-lock.json so as not to re-introduce prior packages or those handled by the jslib refactor since removed from here.
There was a problem hiding this comment.
Maybe I should have said "undo" rather than "revert"... I didn't use git revert, instead I did what you've suggested: I updated the line in package.json then ran npm i again, then committed changes.
I did a rough check of the changes in package-lock.json just now to make sure, and these changes all seem to be dependencies of ldapjs, I assume triggered by the downgrade.
Objective
Revert the update to the
ldapjsdependency which I did here. The update appears to have broken syncing for some users. Reverting to our fork until we can diagnose the issue.This will need to be cherry-picked to
rcafter merge.