Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-3647] Changing Vault timeout settings to 'Log out' and 'Never' logs out the user #6723

Merged
merged 3 commits into from
Nov 7, 2023
Merged

[PM-3647] Changing Vault timeout settings to 'Log out' and 'Never' logs out the user #6723

merged 3 commits into from
Nov 7, 2023

Conversation

andrebispo5
Copy link
Contributor

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fix bug where changing Vault timeout settings to 'Log out' and 'Never' logs out the user.

Code changes

There was a problem changing the store location disk <-> memory because the timeout was changed before getting the values.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@andrebispo5 andrebispo5 requested review from a team and ike-kottlowski and removed request for a team October 27, 2023 14:57
@andrebispo5 andrebispo5 requested a review from a team as a code owner October 27, 2023 14:57
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Oct 27, 2023
JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bitwarden-bot
Copy link

bitwarden-bot commented Oct 27, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 8af19ac8-3f0d-4654-a0b9-86b33b2a8cd6

No New Or Fixed Issues Found

eliykat
eliykat approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please make a follow-up task to move VaultTimeoutSettingsService into auth team code ownership. Thanks!

@andrebispo5 andrebispo5 removed the needs-qa Marks a PR as requiring QA approval label Nov 3, 2023
@andrebispo5 andrebispo5 merged commit 1669f35 into master Nov 7, 2023
106 checks passed
@andrebispo5 andrebispo5 deleted the auth/pm-3647/timeout-logout branch November 7, 2023 12:16
BlackDex pushed a commit to BlackDex/bitwarden-clients that referenced this pull request Nov 21, 2023
@andrebispo5 @BlackDex
[PM-3647] Change order of timeout set. (bitwarden#6723)
4ad90fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ike-kottlowski ike-kottlowski ike-kottlowski approved these changes

@JaredSnider-Bitwarden JaredSnider-Bitwarden JaredSnider-Bitwarden approved these changes

@eliykat eliykat eliykat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrebispo5 @bitwarden-bot @eliykat @JaredSnider-Bitwarden @ike-kottlowski