Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4373] Update argon2 to 0.31.1 to fix linux/arm64 install #6605

Closed
wants to merge 1 commit into from

Conversation

jrcichra
Copy link

@jrcichra jrcichra commented Oct 17, 2023

Type of change

- [ x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes #6458

When installing @bitwarden/cli on arm64 the prebuilt binary is not available:

 #24 339.6 npm ERR! node-pre-gyp info using node-pre-gyp@1.0.11
#24 339.6 npm ERR! node-pre-gyp info using node@18.18.2 | linux | arm64
#24 339.6 npm ERR! node-pre-gyp info check checked for "/usr/local/lib/node_modules/@bitwarden/cli/node_modules/argon2/lib/binding/napi-v3/argon2.node" (not found)
#24 339.6 npm ERR! node-pre-gyp http GET https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-linux-arm64-glibc.tar.gz
#24 339.6 npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-linux-arm64-glibc.tar.gz 
#24 339.6 npm ERR! node-pre-gyp WARN Pre-built binaries not installable for argon2@0.31.0 and node@18.18.2 (node-v108 ABI, glibc) (falling back to source compile with node-gyp) 
#24 339.6 npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-linux-arm64-glibc.tar.gz 
#24 339.6 npm ERR! gyp info it worked if it ends with ok

This was addressed in the next patch release, 0.31.1: https://github.com/ranisalt/node-argon2/releases/tag/v0.31.1

Upgrading from 0.31.0 to 0.31.1 in bitwarden/cli will resolve this build issue.

Code changes

  • package.json: Upgraded node-argon2 from 0.31.0 to 0.31.1
    • package-lock.json: Upgraded node-argon2 from 0.31.0 to 0.31.1

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-4373

@bitwarden-bot bitwarden-bot changed the title Update argon2 to 0.31.1 to fix linux/arm64 install [PM-4373] Update argon2 to 0.31.1 to fix linux/arm64 install Oct 17, 2023
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailscd6f2e70-59f4-421a-bb08-3cf70c5720f5

No New Or Fixed Issues Found

@jrcichra
Copy link
Author

I've had success keeping my bitwarden cli pinned to @bitwarden/cli@2023.8.2 until a fix is merged.

@aleksandarristic
Copy link

I've had success keeping my bitwarden cli pinned to @bitwarden/cli@2023.8.2 until a fix is merged.

Thank you, I can confirm that v2023.8.2 seems to be the last working version on arm64 until your PR is merged.

@MGibson1
Copy link
Member

Thank you for your contribution, in the course of dependency updates, it appears that #8073 should resolve this issue. Closing this PR for now. If your build issues are not fixed, we'll need to investigate something further than lib version.

@MGibson1 MGibson1 closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitwarden CLI doesn't build anymore due to retracted node-argon2 dependency
5 participants