Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PS-1830] Updated the autofill.js file to no longer add the 'data.com' attribute to tags #4001

Merged
merged 5 commits into from
Dec 16, 2022

Conversation

hkbertoson
Copy link
Contributor

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR is to resolve issue #725

Code changes

Removed addProp(field, 'userEdited', !!el.dataset['com.browser.browser.userEdited']);

      document.addEventListener('input', function (inputevent) {
          inputevent.a !== false &&
              inputevent.target.tagName.toLowerCase() === 'input' &&
              (inputevent.target.dataset['com.bitwarden.browser.userEdited'] = 'yes');
      }, true);
  • autofill.js Please see above

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2022

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PS-1830

@bitwarden-bot bitwarden-bot changed the title Updated the autofill.js file to no longer add the 'data.com' attribute to tags [PS-1830] Updated the autofill.js file to no longer add the 'data.com' attribute to tags Nov 7, 2022
@hkbertoson hkbertoson marked this pull request as ready for review November 7, 2022 20:29
@djsmith85 djsmith85 linked an issue Dec 7, 2022 that may be closed by this pull request
@djsmith85 djsmith85 self-assigned this Dec 8, 2022
Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkbertoson: Thank you for your contribution!

I spoke with @eliykat about this, and we agree with the findings of @flexagoon and @hkbertoson, that the attribute com.bitwarden.browser.userEdited is no longer needed and can be removed.

Some manual local testing showed no negative side effects to the behaviour of auto-fill.

  1. Please add a comment on line 45 describing your changes -> Something like "Remove setting of attribute com.browser.browser.userEdited on user-inputs" in case you don't have another suggestion
  2. Remove empty line 53
  3. Delete the commented out line 278

@hkbertoson Please address my requested minor-changes and this should be good to pass this on to QA for testing.

@hkbertoson
Copy link
Contributor Author

Got it updated. Thanks!

Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkbertoson Wow, that was quick. Thank you for the quick turnaround. Changes are looking good and I will pass this on to QA.

@djsmith85 djsmith85 added the needs-qa Marks a PR as requiring QA approval label Dec 8, 2022
@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label Dec 16, 2022
@djsmith85
Copy link
Contributor

@hkbertoson This has received approval from QA and is ready to get merged. Thank you for your contribution 👍 This will be included in an upcoming release.

@djsmith85 djsmith85 merged commit 91ff4fc into bitwarden:master Dec 16, 2022
@hkbertoson hkbertoson deleted the hkbertoson/issue725 branch December 16, 2022 16:03
rr-bw pushed a commit that referenced this pull request Jan 10, 2023
…' attribute to tags (#4001)

* Updated the autofill.js file to no longer add the 'data.com' attribute to tags

* Added Comments and removed empty lines
rr-bw pushed a commit that referenced this pull request Jan 10, 2023
…' attribute to tags (#4001)

* Updated the autofill.js file to no longer add the 'data.com' attribute to tags

* Added Comments and removed empty lines
cyprain-okeke pushed a commit that referenced this pull request Jan 11, 2023
…' attribute to tags (#4001)

* Updated the autofill.js file to no longer add the 'data.com' attribute to tags

* Added Comments and removed empty lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invasive when not even in use
4 participants