-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PS-1830] Updated the autofill.js file to no longer add the 'data.com' attribute to tags #4001
Conversation
Thank you for your contribution! We've added this to our internal Community PR board for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkbertoson: Thank you for your contribution!
I spoke with @eliykat about this, and we agree with the findings of @flexagoon and @hkbertoson, that the attribute com.bitwarden.browser.userEdited
is no longer needed and can be removed.
Some manual local testing showed no negative side effects to the behaviour of auto-fill.
- Please add a comment on line 45 describing your changes -> Something like "Remove setting of attribute
com.browser.browser.userEdited
on user-inputs" in case you don't have another suggestion - Remove empty line 53
- Delete the commented out line 278
@hkbertoson Please address my requested minor-changes and this should be good to pass this on to QA for testing.
Got it updated. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkbertoson Wow, that was quick. Thank you for the quick turnaround. Changes are looking good and I will pass this on to QA.
@hkbertoson This has received approval from QA and is ready to get merged. Thank you for your contribution 👍 This will be included in an upcoming release. |
…' attribute to tags (#4001) * Updated the autofill.js file to no longer add the 'data.com' attribute to tags * Added Comments and removed empty lines
…' attribute to tags (#4001) * Updated the autofill.js file to no longer add the 'data.com' attribute to tags * Added Comments and removed empty lines
…' attribute to tags (#4001) * Updated the autofill.js file to no longer add the 'data.com' attribute to tags * Added Comments and removed empty lines
Type of change
Objective
This PR is to resolve issue #725
Code changes
Removed
addProp(field, 'userEdited', !!el.dataset['com.browser.browser.userEdited']);
Before you submit