-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-19061 - Innovation Sprint - OPAQUE Login Strategy #13832
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## innovation/opaque #13832 +/- ##
==================================================
Coverage 6.00% 6.00%
==================================================
Files 27 27
Lines 1665 1665
==================================================
Hits 100 100
Misses 1565 1565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
New Issues (60)Checkmarx found the following issues in this Pull Request
|
…rvices so clean that up.
…est model to auth
…n logic into login comp (2) update PasswordLoginCredentials to include kdfConfig to pass into login strat
…oginMasterKey (2) Refactor makePrePasswordLoginMasterKey to accept an optional KdfConfig so we can keep the logic tested on the LoginStrategyService
…on/opaque-login-strategy
|
Merging into feature as requested by @JaredSnider-Bitwarden . The failing builds relate to the SDK only and are expected because we can't make CI pull the sdk from a feature branch. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19061
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes