-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17668] Move DeviceTrustService to KM ownership #13194
[PM-17668] Move DeviceTrustService to KM ownership #13194
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13194 +/- ##
=======================================
Coverage 36.39% 36.39%
=======================================
Files 3173 3173
Lines 92327 92327
Branches 16724 16724
=======================================
Hits 33601 33601
Misses 56132 56132
Partials 2594 2594 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just check the failing tests.
I think the test failures are unrelated so LGTM. |
This is failures with code signing the macOS pacakge and not related to the change. Looks to be happening on main for a bit now. |
Could you update https://github.com/bitwarden/clients/blob/main/.github/codecov.yml ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from @mzieniukbw's comment on codecov, this LGTM, approving and will re-approve if/when you address that comment too.
Added dd6b95e |
c91e33d
7c0c812
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -12,7 +12,7 @@ component_management: | |||
paths: | |||
- apps/browser/src/key-management/biometrics/** | |||
- apps/cli/src/key-management/cli-biometrics-service.ts | |||
- apps/desktop/destkop_native/core/src/biometric/** | |||
- apps/desktop/desktop_native/core/src/biometric/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice catch
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17668
📔 Objective
The purpose of this PR is to move
DeviceTrustService
to KM ownership.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes