[PM-17668] Move DeviceTrustService to KM ownership

[Thomas-Avery]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17668

📔 Objective

The purpose of this PR is to move DeviceTrustService to KM ownership.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 4e073a4f-3cf5-4028-b543-f44c5cde8711

Great job, no security vulnerabilities found in this Pull Request

[codecov]

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 36.39%. Comparing base (41e1d4e) to head (36cef67).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
libs/angular/src/services/jslib-services.module.ts	0.00%	2 Missing ⚠️
apps/browser/src/background/main.background.ts	0.00%	1 Missing ⚠️
libs/angular/src/auth/guards/redirect.guard.ts	0.00%	1 Missing ⚠️
...r/src/auth/guards/tde-decryption-required.guard.ts	0.00%	1 Missing ⚠️
...tion-options/login-decryption-options.component.ts	0.00%	1 Missing ⚠️
...a-auth-request/login-via-auth-request.component.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13194   +/-   ##
=======================================
  Coverage   36.39%   36.39%           
=======================================
  Files        3173     3173           
  Lines       92327    92327           
  Branches    16724    16724           
=======================================
  Hits        33601    33601           
  Misses      56132    56132           
  Partials     2594     2594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rr-bw]

Looks good, just check the failing tests.

[quexten]

I think the test failures are unrelated so LGTM.

[Thomas-Avery]

Looks good, just check the failing tests.

This is failures with code signing the macOS pacakge and not related to the change. Looks to be happening on main for a bit now.

[mzieniukbw]

Could you update https://github.com/bitwarden/clients/blob/main/.github/codecov.yml ?
I assume it falls under Lock ?

[quexten]

Aside from @mzieniukbw's comment on codecov, this LGTM, approving and will re-approve if/when you address that comment too.

[Thomas-Avery]

Could you update https://github.com/bitwarden/clients/blob/main/.github/codecov.yml ? I assume it falls under Lock ?

Added dd6b95e

[mzieniukbw]

LGTM

[mzieniukbw]

👍 nice catch

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud