Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16102] Prevent item action height overflow #12588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Dec 26, 2024

๐ŸŽŸ๏ธ Tracking

PM-16102

๐Ÿ“” Objective

The :after height that was added in this ticket was just a little bit too tall for the item container, and was causing tiny scrollbars to appear on each item in Storybook. I was not able to reproduce in the extension. This PR reduces the height slightly to prevent it from overflowing the container in both regular and compact modes.

๐Ÿ“ธ Screenshots

Before:

Screen.Recording.2024-12-26.at.11.11.05.AM.mov

After:

Screen.Recording.2024-12-26.at.11.11.27.AM.mov

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vleague2 vleague2 requested a review from a team as a code owner December 26, 2024 16:14
@vleague2 vleague2 requested a review from willmartian December 26, 2024 16:14
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 33.79%. Comparing base (ef70f7d) to head (81fd475).
Report is 1 commits behind head on main.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12588   +/-   ##
=======================================
  Coverage   33.78%   33.79%           
=======================================
  Files        2912     2912           
  Lines       90699    90699           
  Branches    17152    17152           
=======================================
+ Hits        30641    30648    +7     
+ Misses      57672    57665    -7     
  Partials     2386     2386           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 2ef2fa2b-7087-4e08-9304-178fc4b1d9d3

No New Or Fixed Issues Found

@vleague2 vleague2 requested review from merissaacosta and removed request for willmartian December 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant