Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14999] Remove Sequentialize #12113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

justindbaur
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14999

📔 Objective

Sequentialize was used to give back a cached unfulfilled promise back to later callers. But we've come a long way since this was added and you know what's even better? Not calling this method to many times in a short period of time.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested review from a team as code owners November 22, 2024 21:50
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.76%. Comparing base (eb7b2cd) to head (3b5417d).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12113      +/-   ##
==========================================
- Coverage   33.78%   33.76%   -0.02%     
==========================================
  Files        2912     2911       -1     
  Lines       90706    90664      -42     
  Branches    17155    17152       -3     
==========================================
- Hits        30646    30614      -32     
+ Misses      57672    57663       -9     
+ Partials     2388     2387       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coroiu
coroiu previously approved these changes Nov 25, 2024
gbubemismith
gbubemismith previously approved these changes Nov 29, 2024
Copy link
Member

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse6d194ed-f59d-4c1f-ab36-d9a0f6e31ff0

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants