Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14901] Fix ssh keys being empty when creating while filter is active #11985

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Nov 13, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14901

📔 Objective

Creation while filtering to the ssh key category was broken since generate was only invoked when switching item type. Now it also generates when creating the component - if the active item type is ssh keys. Additionally an issue causing error logs is fixed when the private key was not yet set.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from a team as a code owner November 13, 2024 14:50
@quexten quexten requested review from shane-melton and removed request for shane-melton November 13, 2024 14:50
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 33.46%. Comparing base (0cfe18a) to head (5aff067).
Report is 54 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../desktop/src/vault/app/vault/add-edit.component.ts 0.00% 8 Missing ⚠️
libs/common/src/vault/models/view/ssh-key.view.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11985      +/-   ##
==========================================
- Coverage   33.48%   33.46%   -0.02%     
==========================================
  Files        2844     2844              
  Lines       89044    89052       +8     
  Branches    16987    16992       +5     
==========================================
- Hits        29812    29805       -7     
- Misses      56887    56902      +15     
  Partials     2345     2345              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@quexten quexten requested a review from shane-melton November 14, 2024 18:58
@quexten quexten merged commit 06b5c79 into main Nov 20, 2024
71 checks passed
@quexten quexten deleted the km/pm-14901/ssh-key-creation-broken-with-filter branch November 20, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants