Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-1840 - Update for automatic version bump calculation #19

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Feb 29, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR updates the Version Bump workflow to use the version-next action to automatically calculate the next release version if an override version is not specified.

Code changes

  • .github/workflows/version-bump.yml: Move around steps and add required logic to make use of the version-next action.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@vgrassia vgrassia requested a review from a team February 29, 2024 18:22
@vgrassia vgrassia self-assigned this Feb 29, 2024
@vgrassia vgrassia added the devops Pull requests related to DevOps work label Feb 29, 2024
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 29, 2024

Logo
Checkmarx One – Scan Summary & Detailsdf56c7f7-f563-43ea-9091-c3600140b088

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 35 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 97 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 19 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 112 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 104 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 77
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 25

@vgrassia vgrassia marked this pull request as ready for review March 13, 2024 14:32
@vgrassia vgrassia merged commit 2f5a715 into main Mar 13, 2024
22 checks passed
@vgrassia vgrassia deleted the devops-1840_automatic-version-bump-calc branch March 13, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Pull requests related to DevOps work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants