Attempt to capture panics with GDB #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firmware-binaries/.cargo/config.toml
Outdated
Comment on lines
8
to
11
| "-C", "target-feature=+f", | ||
| "-C", "force-frame-pointers=yes", | ||
| "-C", "force-unwind-tables=yes" |
There was a problem hiding this comment.
Could you add an XXX: Seem to be ignored?
There was a problem hiding this comment.
Wait the other flags also seem to be ignored right? When we add gooblygook there, we don't get any warnings or errors.
martijnbastiaan
approved these changes
Dec 3, 2024
Draft
martijnbastiaan
added a commit
that referenced
this pull request
Dec 4, 2024
We think #690 fixed our nightly issues. At the very least, we cannot reproduce it locally anymore. However, we've also seen that nightly fails more often than local runs, so we'll run nightly a bunch of times in the coming days to see if we've actually fixed things.
Merged
martijnbastiaan
added a commit
that referenced
this pull request
Dec 4, 2024
We think #690 fixed our nightly issues. At the very least, we cannot reproduce it locally anymore. However, we've also seen that nightly fails more often than local runs, so we'll run nightly a bunch of times in the coming days to see if we've actually fixed things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some issues here, e.g. it seems like the maximum stack trace depth on a panic is 2 no matter what I try, but otherwise it seems to have reduced the number of times the TCP test fails (likely by replacing
startwithcontinuein the GDB script). Otherwise, this PR:firmware-supportthat provides a method that GDB canbreakon (though it should preferentially break oncore::panicking::panicorrust_begin_unwindfor the time being) in order to grab a backtrace of the program and exit.