Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle case where ServiceAddress is empty and node address is not #18

Merged
merged 2 commits into from
Mar 27, 2017
Merged

handle case where ServiceAddress is empty and node address is not #18

merged 2 commits into from
Mar 27, 2017

Conversation

zambien
Copy link

@zambien zambien commented Mar 24, 2017

Resolve #17

bitsofinfo
bitsofinfo reviewed Mar 24, 2017
View reviewed changes
Copy link
Owner

@bitsofinfo bitsofinfo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a null check on service address before calling equals, also ensure the unit tests pass

@zambien
Copy link
Author

zambien commented Mar 24, 2017

Unit tests pass. Looks like there are some failures in the travis build due to not being able to download Consul

@bitsofinfo bitsofinfo merged commit 65ffefd into bitsofinfo:master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsofinfo bitsofinfo bitsofinfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zambien @bitsofinfo