Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set max_market_fee to 0 in create_asset #303

Closed
christophersanborn opened this issue May 14, 2021 · 1 comment
Closed

Can't set max_market_fee to 0 in create_asset #303

christophersanborn opened this issue May 14, 2021 · 1 comment

Comments

@christophersanborn
Copy link
Member

christophersanborn commented May 14, 2021

In BitShares().create_asset(), at

if not max_market_fee:

if not max_market_fee:
    max_market_fee = max_supply

Should probably be:

if max_market_fee is None:
    max_market_fee = max_supply

Because if I pass in max_market_fee=0, the existing conditional evaluates true and overrides my explicit zero.

@xeroc
Copy link
Member

xeroc commented May 25, 2021

Feel free to make a pull request :D

@xeroc xeroc closed this as completed May 13, 2022
xeroc added a commit that referenced this issue May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants