Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSIP59: Adjustment of MSSR and MCR through voting #145

Merged
merged 4 commits into from
Feb 23, 2019
Merged

BSIP59: Adjustment of MSSR and MCR through voting #145

merged 4 commits into from
Feb 23, 2019

Conversation

bitcrab
Copy link
Contributor

@bitcrab bitcrab commented Feb 15, 2019

create bsip59

@bitcrab bitcrab changed the title create bsip59 BSIP59: Adjustment of MSSR and MCR through voting Feb 15, 2019
@pmconrad pmconrad mentioned this pull request Feb 15, 2019
Closed
pmconrad
pmconrad reviewed Feb 15, 2019
View reviewed changes
bsip-0059.md Outdated
Title: Adjustment of MSSR and MCR through voting
Authors: Jerry Liu <bitcrab@qq.com>
Status: Draft
Type: Protocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to Informational

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

bsip-0059.md Outdated

It’s best for bitCNY to be always in phase 2, the system should always avoid bitCNY to fall in phase 4 in comparatively high BTS price.
If bitCNY fall in phase 3 for long time, it will be good to reduce the premium by reducing MSSR.
Decreasing of MCR will help to supply more bitCNY and help bitCNY to jump from phase 3 to phase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete this sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed, thanks.

@bitcrab
Update bsip-0059.md
2c037ed 
fixed some text errors.
pmconrad
pmconrad approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

xeroc
xeroc previously requested changes Feb 22, 2019
View reviewed changes
Copy link
Member

@xeroc xeroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please change the created date to the correct year.

bsip-0059.md Outdated Show resolved Hide resolved
@ryanRfox
Copy link
Contributor

Thank you @bitcrab for correcting the date. I will dismiss the pending review for @xeroc and proceed to merge.

@ryanRfox ryanRfox dismissed xeroc’s stale review February 23, 2019 16:32

The date is now correct.

@ryanRfox ryanRfox merged commit 71812b8 into bitshares:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

@xeroc xeroc xeroc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bitcrab @ryanRfox @xeroc @pmconrad