Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of most extra cmake modules #177

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Get rid of most extra cmake modules #177

merged 1 commit into from
Nov 6, 2019

Conversation

pmconrad
Copy link

@pmconrad pmconrad commented Nov 4, 2019

No description provided.

@abitmore abitmore added this to the core release 4.1.0 milestone Nov 4, 2019
jmjatlanta
jmjatlanta approved these changes Nov 6, 2019
View reviewed changes
Copy link

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tested on Ubuntu 18.04 / Boost 1.65.1. I also tested with the develop branch of bitshares-core. No issues. Thanks!

@pmconrad pmconrad merged commit 41aaa6c into master Nov 6, 2019
@pmconrad pmconrad deleted the cmake_simplification branch November 6, 2019 14:50
@abitmore abitmore mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjatlanta jmjatlanta jmjatlanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
core release 5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pmconrad @jmjatlanta @abitmore