Support Building on OpenBSD #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
suggested changes
Aug 14, 2019
|
Please rebase on latest master. |
crypto-ape
force-pushed
the
support_building_on_open_bsd
branch
from
ddb1f3e to
727e09e
Compare
pmconrad
approved these changes
Aug 17, 2019
|
Haven't tested on OpenBSD, but looking good. Thanks! |
abitmore
reviewed
Mar 28, 2020
| #ifdef __APPLE__ | ||
| #if defined(__APPLE__) | ||
| #elif defined(__OpenBSD__) | ||
| void to_variant( size_t s, variant& v, uint32_t max_depth ) { v = variant( int64_t(s) ); } |
There was a problem hiding this comment.
Not sure whether this is really needed. I suspect it's unused since macOS build doesn't rely on it.
There was a problem hiding this comment.
OK, found the code for macOS in variant.hpp implemented with inline.
There was a problem hiding this comment.
Using int64_t but not uint64_t here is probably wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Monkeys!
I had some interest in being able to run a BitShares node on OpenBSD.
This PR with this bitshares-core PR contains changes allowing to successfully build the code base under OpenBSD.
The work is not done yet, because, at least for me, the compiled executables crash (with a segmentation fault) on calling some boost functions (hastily done some call tracing).
I plan to investigate further. So far, I wanted to share and close the work already done.
Ape out!