Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JSONRPC error handling #135

Merged
merged 2 commits into from
May 28, 2019

Conversation

pmconrad
Copy link

Fixes bitshares/bitshares-core#1688

Generally improves error handling and standards conformance. Conforming clients should not be affected.

abitmore
abitmore previously approved these changes May 24, 2019
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

src/rpc/websocket_api.cpp Outdated Show resolved Hide resolved
src/rpc/websocket_api.cpp Outdated Show resolved Hide resolved
src/rpc/websocket_api.cpp Show resolved Hide resolved
src/rpc/websocket_api.cpp Outdated Show resolved Hide resolved
@abitmore abitmore dismissed their stale review May 24, 2019 18:19

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No response from node while creating asset with wrong value of max_supply
2 participants