Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake to C++14 #131

Merged
merged 1 commit into from
May 21, 2019
Merged

Update CMake to C++14 #131

merged 1 commit into from
May 21, 2019

Conversation

jmjatlanta
Copy link

@jmjatlanta jmjatlanta commented May 20, 2019

This PR changes the CMakeLists.txt file to use C++14, and removes references to C++11.

This also fixes a POSIX / Windows incompatibility in a function that Windows does not use. (Update: see #132)

NOTE: Separate issue: To compile FC alone on Windows, the CMakeModules/FindBoost.cmake needs to be deleted. Compiling as part of bitshares-core ignores that file. FindBoost.cmake should probably be permanently removed once we handle the pthread/boost/fc issue.

src/rpc/cli.cpp Outdated Show resolved Hide resolved
@pmconrad
Copy link

Please rebase -i to get rid of the rolled back change.

@pmconrad
Copy link

Also see comment in core PR:

it would be good to have a small C++-14 only change in both fc and core to verify that the settings are complete and have the intended effec

@pmconrad
Copy link

I've got one - std::enable_if_t as used in optional API parameters exists since C++-14 only. :-/

@jmjatlanta
Copy link
Author

Also see comment in core PR:

it would be good to have a small C++-14 only change in both fc and core to verify that the settings are complete and have the intended effec

capturing local variables in lambdas produced a warning in gcc when compiling with c++11 specified and c++14 not required. Warning disappears with these changes. Would you like something that breaks the c++11 build instead of just warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants