Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log block ID of new received block #937

Merged
merged 1 commit into from
May 23, 2018
Merged

Log block ID of new received block #937

merged 1 commit into from
May 23, 2018

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented May 20, 2018

Related to #517 (but didn't fix it entirely).

With block IDs logged, when a node got duplicate 'Got Block' notices, it's easier to identify the real reason: is it a threading/latency issue, or double producing (aka "nothing-at-stake") issue.

  • This is double producing (same block number and different IDs):

2018-05-20T10:48:51 th_a:invoke handle_block handle_block ] Got block: #27140381 019e211dad54b3608441d1a2379d16b6e5e9b62b time: 2018-05-20T10:48:51 latency: 170 ms from: verbaltech2 irreversible: 27140360 (-21) application.cpp:513
2018-05-20T10:48:51 th_a:invoke handle_block handle_block ] Got block: #27140381 019e211d5bc01243e91bb5b5755467c5461db754 time: 2018-05-20T10:48:51 latency: 499 ms from: verbaltech2 irreversible: 27140363 (-18) application.cpp:513

  • This is latency/threading issue (same block number and same ID):

2018-05-20T11:00:03 th_a:invoke handle_block handle_block ] Got block: #27140604 019e21fcbb243138321653a2d59de4f9d4161d4f time: 2018-05-20T11:00:00 latency: 3614 ms from: fox irreversible: 27140578 (-26) application.cpp:513
2018-05-20T11:00:04 th_a:invoke handle_block handle_block ] Got block: #27140604 019e21fcbb243138321653a2d59de4f9d4161d4f time: 2018-05-20T11:00:00 latency: 4595 ms from: fox irreversible: 27140578 (-26) application.cpp:513
2018-05-20T11:00:04 th_a:invoke handle_block handle_block ] Got block: #27140604 019e21fcbb243138321653a2d59de4f9d4161d4f time: 2018-05-20T11:00:00 latency: 4600 ms from: fox irreversible: 27140578 (-26) application.cpp:513

@abitmore abitmore added this to the 201805 - Non-Consensus-Changing Release milestone May 20, 2018
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@abitmore
Copy link
Member Author

Can anyone help check why Docker failed to build this PR?

@pmconrad
Copy link
Contributor

@xeroc can you add "pmconrad" to bitshares docker organization?

@abitmore
Copy link
Member Author

@pmconrad FYI you should have the permission now (info from @xeroc).

@pmconrad
Copy link
Contributor

pmconrad commented May 23, 2018

Thanks @xeroc !
No comprehensible log message found, triggered rebuild and it went through.

@abitmore abitmore merged commit 9e62bdf into develop May 23, 2018
@abitmore abitmore deleted the abit-more-logging branch May 23, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants