Change assert() to FC_ASSERT. #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcialvieira thanks! Please follow the steps described in #511 (just updated) to see if the changes will work. |
|
Need to change the base branch to |
abitmore
added
the
2a Discussion Needed
|
IMO it is too dangerous to simply search&replace. Each of these asserts needs to be carefully reviewed
We should close this PR and rather remove/replace assert's whenever we come across them. Once we've got rid of most of them we can tackle the rest in one go. |
|
@pmconrad agreed. Closing. @marcialvieira thanks for contribution anyway. Sorry for wasted your time/efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another commit to the issue #511