Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused index.cpp file removed #638

Merged
merged 1 commit into from
Feb 8, 2018
Merged

unused index.cpp file removed #638

merged 1 commit into from
Feb 8, 2018

Conversation

ihla
Copy link

@ihla ihla commented Feb 5, 2018

the deleted libraries/chain/index.cpp contains identical code as the libraries/db/index.cpp, since the former is not included in any cmake file, i guess it can be removed from repo

@oxarbitrage oxarbitrage self-requested a review February 5, 2018 15:47
oxarbitrage
oxarbitrage approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with you, file is there probably by mistake. project compiles fine without it. nice find.

@abitmore abitmore added this to the Next Non-Consensus-Changing Release milestone Feb 8, 2018
@oxarbitrage oxarbitrage merged commit 24aee5f into bitshares:develop Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201803 Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ihla @oxarbitrage @abitmore