Refactor code about object_id and object_id_type #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
force-pushed
the
fix-code-smells
branch
from
3e42b92 to
9be7a39
Compare
And fix some other code smells.
Remove wallet_api_impl::account_id_to_string(account_id_type id)
abitmore
force-pushed
the
fix-code-smells
branch
2 times, most recently
from
56bebf1 to
bc91606
Compare
And fix some other code smells
abitmore
force-pushed
the
fix-code-smells
branch
from
9881a62 to
b5de525
Compare
to fix a compiler warning
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code about
object_idandobject_id_type, and fix some other code smells.