-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile, default_config.ini and bitsharesentry.sh #1825
Conversation
…had libcurl issues (have the issue on telegram) Updated bitsharesentry.sh to add support to the BITSHARESD_ES_START_AFTER_BLOCK env var, to tell the witness_node to only start throwing data onto ES after the specified block Updated default_config as per test-3.2.0 release
Thank you for sending. I cant prove the baseimage thing but according to telegram discussions it seems to fix the curl issue. I sent a small change of the default participation value, rest looks good. |
Thanks, i am unsure if we will include the elasticsearch in the |
docker/default_config.ini
Outdated
@@ -35,7 +35,7 @@ rpc-endpoint = 0.0.0.0:8090 | |||
enable-stale-production = false | |||
|
|||
# Percent of witnesses (0-99) that must be participating in order to produce blocks | |||
required-participation = false | |||
required-participation = 33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please comment it out instead. There's really no reason to set it explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
FROM phusion/baseimage:0.10.1 | |||
FROM ubuntu:bionic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not using stock ubuntu images for a reason. See https://phusion.github.io/baseimage-docker/ for explanations.
phusion/baseimage:0.11 is based on Ubuntu-18.04 - did you have a specific reason to move away from phusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree on keeping phusion by changing to 0.11
if this gets the curl issue fixed. Thanks for the explications @pmconrad and sorry for not noticing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will rebuild using phusion 0.11, if everything goes fine and starts with no issues, i'll push the changes, thanks a lot for the input guys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds/Runs succesfully on 0.11, pushed code
FROM Image is now phusion/baseimage:0.11 Commented Out required-participation from default_config.ini
Excellent, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
Update Dockerfile to use ubuntu:bionic instead of phusion baseimage, had libcurl issues (have the issue on telegram)
Updated bitsharesentry.sh to add support to the BITSHARESD_ES_START_AFTER_BLOCK env var, to tell the witness_node to only start throwing data onto ES after the specified block
Updated default_config as per test-3.2.0 release