Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile, default_config.ini and bitsharesentry.sh #1825

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Update Dockerfile, default_config.ini and bitsharesentry.sh #1825

merged 3 commits into from
Jun 24, 2019

Conversation

tperalta82
Copy link
Contributor

Update Dockerfile to use ubuntu:bionic instead of phusion baseimage, had libcurl issues (have the issue on telegram)

Updated bitsharesentry.sh to add support to the BITSHARESD_ES_START_AFTER_BLOCK env var, to tell the witness_node to only start throwing data onto ES after the specified block

Updated default_config as per test-3.2.0 release

…had libcurl issues (have the issue on telegram)

Updated bitsharesentry.sh to add support to the BITSHARESD_ES_START_AFTER_BLOCK env var, to tell the witness_node to only start throwing data onto ES after the specified block
Updated default_config as per test-3.2.0 release
docker/default_config.ini Outdated Show resolved Hide resolved
@oxarbitrage
Copy link
Member

Thank you for sending. I cant prove the baseimage thing but according to telegram discussions it seems to fix the curl issue. I sent a small change of the default participation value, rest looks good.

oxarbitrage
oxarbitrage previously approved these changes Jun 23, 2019
@oxarbitrage
Copy link
Member

Thanks, i am unsure if we will include the elasticsearch in the release branch so i am waiting to other opinions from the core team before merging, most probably tomorrow.

@@ -35,7 +35,7 @@ rpc-endpoint = 0.0.0.0:8090
enable-stale-production = false

# Percent of witnesses (0-99) that must be participating in order to produce blocks
required-participation = false
required-participation = 33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment it out instead. There's really no reason to set it explicitly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM phusion/baseimage:0.10.1
FROM ubuntu:bionic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using stock ubuntu images for a reason. See https://phusion.github.io/baseimage-docker/ for explanations.
phusion/baseimage:0.11 is based on Ubuntu-18.04 - did you have a specific reason to move away from phusion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on keeping phusion by changing to 0.11 if this gets the curl issue fixed. Thanks for the explications @pmconrad and sorry for not noticing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rebuild using phusion 0.11, if everything goes fine and starts with no issues, i'll push the changes, thanks a lot for the input guys

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds/Runs succesfully on 0.11, pushed code

@pmconrad
Copy link
Contributor

Resolves #1823 #1824

@pmconrad pmconrad added this to the 3.2.0 - Feature Release milestone Jun 24, 2019
FROM Image is now phusion/baseimage:0.11
Commented Out required-participation from default_config.ini
@pmconrad
Copy link
Contributor

Excellent, thanks!

Copy link
Member

@xeroc xeroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants