Travis / sonar fixes #1750
Merged
Travis / sonar fixes #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
Note: new PR #2102 changes the behaviors. Specifically,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sonar scans haven't been working properly for a while. It turned out that changes in our travis build script were responsible - apparently the sonar build wrapper doesn't work incrementally, so we must build all to-be-scanned targets in one go instead of sequentially.
Also made some other improvements to the travis script, most noteworthy is that the sonar stuff will no longer fail the build. This should lead to fewer red flags, but we may have to trigger rebuilds sometime to actually see the sonar results.
Also fixes sonar target branch detection (more precisely, makes the target branch explicit for develop/hardfork, which will require an additional change when merging to hardfork).