1196 serialization #1714
Merged
1196 serialization #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
force-pushed
the
1196_serialization
branch
from
9cb6b5f to
22ee874
Compare
|
Rebased + bumped fc |
|
Looks good to me. (Don't know why Travis tries to build "push" when the source branch is not in this repository) |
My fault. I accidentally pushed to origin yesterday and deleted the branch immediately afterwards. Apparently I was too slow to prevent travis being triggered but quick enough to make travis fail. :-/ Just ignore the push build. |
abitmore
approved these changes
May 10, 2019
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1196
Requires bitshares/bitshares-fc#122
Tested on an emulated big-endian PPC64 system - compiles, syncs, replays, tests ok, snapshot comparison at block 2,000,000 without plugins produced identical results. (Emulation is dead slow, didn't test a full replay.)
Note: this bumps the minimum required boost version to 1.58.