check max_supply before borrowing MPAs

[jmjatlanta]

Fixes #1465

[pmconrad]

What about existing MPAs and their max_supply?
I think we need hardfork protection on the new FC_ASSERT and some logic to adapt max_supply of existing bitAssets at hardfork time, if necessary.

[jmjatlanta]

and some logic to adapt max_supply of existing bitAssets at hardfork time, if necessary.

How do you see this working? My thought: At the hardfork, flip through all bitAssets, if current supply is greater than max supply, adjust max supply to equal current supply. What if that number is greater than GRAPHENE_MAX_SHARE_SUPPLY?

[pmconrad]

Shouldn't happen due to softfork protection. If it does happen set max_supply to GRAPHENE_MAX_SHARE_SUPPLY.

[pmconrad]

Test still failing because after generate_blocks, alice is no longer a valid reference (in line 2057).

[jmjatlanta]

Test still failing because after generate_blocks, alice is no longer a valid reference (in line 2057).

Gee wiz. It passed for me. The problem must be on your end! :-D

Fixed reference, tested in Ubuntu 18.10 in both Debug and Release mode.

Hardfork protection added

[pmconrad]

Thanks!

[cogutvalera]

Thanks