Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating cURL into cmake #1336

Merged
merged 5 commits into from
Oct 8, 2018
Merged

Integrating cURL into cmake #1336

merged 5 commits into from
Oct 8, 2018

Conversation

abitmore
Copy link
Member

The original PR is #1329, will continue the work in this PR.

Todo:

@abitmore abitmore added this to the 201810 - Feature Release milestone Sep 20, 2018
@ryanRfox
Copy link
Contributor

@jmjatlanta Do you have time and an environment to test this?

@jmjatlanta
Copy link
Contributor

I have a macOS and Ubuntu 18.04 environment. I need to take a longer look at my Windows VM and figure out why I can't build there. It has never worked (seems to be something fishy with cmake's findBoost.cmake). I will attack mac and linux first, and then see what I can do for Windows.

jmjatlanta
jmjatlanta approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows: Using the instructions at WinDevEnv I built the develop branch. It failed due to not finding the header file curl.h. I then checked out the curl-cmake branch and built it without errors.

I then tested the curl-cmake branch on Ubuntu 18.04. It also built without errors.

@oxarbitrage
Copy link
Member

added https://github.com/bitshares/bitshares-core/wiki/WinDevEnv

@oxarbitrage oxarbitrage self-requested a review October 3, 2018 15:06
@oxarbitrage
Copy link
Member

added WinDevEnv to wiki index https://github.com/bitshares/bitshares-core/wiki#building

oxarbitrage
oxarbitrage approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elasticsearch plugins working ok with this changes from linux.

@oxarbitrage oxarbitrage merged commit 42e2342 into develop Oct 8, 2018
@TheTaconator TheTaconator mentioned this pull request Oct 15, 2018
Closed
@abitmore abitmore deleted the curl-cmake branch February 5, 2019 21:12
@abitmore abitmore restored the curl-cmake branch February 5, 2019 21:12
@abitmore abitmore deleted the curl-cmake branch February 5, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@jmjatlanta jmjatlanta jmjatlanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201810 - Feature Release
Development

Successfully merging this pull request may close these issues.
4 participants
@abitmore @ryanRfox @jmjatlanta @oxarbitrage