Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use get_account_from_string in get_account_limit_orders #1168

Merged
merged 3 commits into from
Jul 22, 2018
Merged

use get_account_from_string in get_account_limit_orders #1168

merged 3 commits into from
Jul 22, 2018

Conversation

oxarbitrage
Copy link
Member

for issue #1164

alfredo@alfredo-Inspiron-5559 ~/CLionProjects/issue1164 $ ./tests/chain_test -t database_api_tests/get_account_limit_orders
Random number generator seeded to 1532213071
GRAPHENE_TESTING_GENESIS_TIMESTAMP is 1431700000
Running 1 test case...
2671843ms th_a       db_management.cpp:153         open                 ] Wiping object_database due to missing or wrong version
2671843ms th_a       object_database.cpp:93        wipe                 ] Wiping object database...
2671843ms th_a       object_database.cpp:95        wipe                 ] Done wiping object databse.
2671843ms th_a       object_database.cpp:106       open                 ] Opening object database from /tmp/graphene-tmp/7535-4486-3107-e57a ...
2671843ms th_a       object_database.cpp:111       open                 ] Done opening object database.
2671852ms th_a       database_api.cpp:292          database_api_impl    ] creating database api 69139008
2671852ms th_a       database_api.cpp:311          ~database_api_impl   ] freeing database api 69139008
2671852ms th_a       db_management.cpp:194         close                ] Rewinding from 1 to 0
2671852ms th_a       db_management.cpp:204         close                ] Database close unexpected exception: {"code":10,"name":"assert_exception","message":"Assert Exception","stack":[{"context":{"level":"error","file":"fork_database.cpp","line":41,"method":"pop_block","hostname":"","thread_name":"th_a","timestamp":"2018-07-21T22:44:31"},"format":"_head: no blocks to pop","data":{}},{"context":{"level":"warn","file":"db_block.cpp","line":439,"method":"pop_block","hostname":"","thread_name":"th_a","timestamp":"2018-07-21T22:44:31"},"format":"","data":{}}]}

*** No errors detected
alfredo@alfredo-Inspiron-5559 ~/CLionProjects/issue1164 $

@oxarbitrage oxarbitrage mentioned this pull request Jul 21, 2018
Closed
abitmore
abitmore requested changes Jul 22, 2018
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please fix in-code documentation.

libraries/app/include/graphene/app/database_api.hpp
@@ -298,7 +298,7 @@ class database_api
* was just canceled accidentally, in such case, the result orders' price may lower or equal to start_price,
* but orders' id greater than start_id
*/
vector<limit_order_object> get_account_limit_orders( const string& name_or_id,
vector<limit_order_object> get_account_limit_orders( const string& account_name_or_id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update comment about this variable. Scroll up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated at bd5c842

abitmore
abitmore approved these changes Jul 22, 2018
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

abitmore
abitmore requested changes Jul 22, 2018
View reviewed changes
libraries/app/include/graphene/app/database_api.hpp Outdated
@@ -291,14 +291,14 @@ class database_api
* @return List of orders from @ref name_or_id to the corresponding account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is another one.

@abitmore abitmore merged commit 31554c1 into bitshares:develop Jul 22, 2018
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
2 participants
@oxarbitrage @abitmore