Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_required_signatures call in database_api_impl is missing a parameter #2087

Closed
1 of 17 tasks
pmconrad opened this issue Jan 2, 2020 · 2 comments · Fixed by #2138
Closed
1 of 17 tasks

get_required_signatures call in database_api_impl is missing a parameter #2087

pmconrad opened this issue Jan 2, 2020 · 2 comments · Fixed by #2138
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
4.0.0 - Protocol ...

Comments

@pmconrad
Copy link
Contributor

pmconrad commented Jan 2, 2020

Bug Description
The call here is lacking another boolean parameter. See this call for comparison.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore
Copy link
Member

abitmore commented Jan 2, 2020 •
edited
Loading

#2048 is related. Just noticed that it's not related to custom active authorities (BSIP40) but authentication of custom operations (#210).

@abitmore abitmore added 3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive labels Jan 29, 2020
abitmore added a commit that referenced this issue Apr 10, 2020
@abitmore
Add a missing param in get_required_signatures API
ad51a8d 
Fixes #2087
@abitmore abitmore mentioned this issue Apr 10, 2020
Merged
@abitmore abitmore removed the 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive label Apr 10, 2020
@abitmore abitmore linked a pull request Apr 10, 2020 that will close this issue
Add a missing parameter in get_required_signatures API #2138
Merged
@abitmore
Copy link
Member

Fixed via #2138.

@MichelSantos MichelSantos mentioned this issue May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

Successfully merging a pull request may close this issue.

Add a missing parameter in get_required_signatures API bitshares/bitshares-core
2 participants
@pmconrad @abitmore