Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI wallet: avoid directly overwriting wallet file on exit #1109

Closed
4 of 8 tasks
abitmore opened this issue Jul 2, 2018 · 10 comments
Closed
4 of 8 tasks

CLI wallet: avoid directly overwriting wallet file on exit #1109

abitmore opened this issue Jul 2, 2018 · 10 comments
Assignees
@cogutvalera
Labels
1a Epic High level concept to be addressed. Description should contain a list referencing child User Stories 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 CLI Impact flag identifying the command line interface (CLI) wallet application 6 Security Impact flag identifying system/user security 9c Large Effort estimation indicating TBD
Milestone
201810 - Feature ...

Comments

@abitmore
Copy link
Member

abitmore commented Jul 2, 2018 •
edited by ryanRfox
Loading

One of my wallet files got corrupted today due to disk full. Fortunately I have backed up the keys.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cogutvalera
    • Estimated: 3 hours (Remitted weeks 34-35)
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added 1a Epic High level concept to be addressed. Description should contain a list referencing child User Stories 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 CLI Impact flag identifying the command line interface (CLI) wallet application 6 Security Impact flag identifying system/user security 9c Large Effort estimation indicating TBD labels Jul 2, 2018
@abitmore
Copy link
Member Author

abitmore commented Jul 2, 2018

#1050 is related.

@abitmore abitmore mentioned this issue Jul 27, 2018
Merged
@cogutvalera
Copy link
Member

as an idea: to save wallet file with another filename something like temp wallet file or backup

@cogutvalera
Copy link
Member

only on exit or in save_wallet_file ?

cogutvalera pushed a commit to cogutvalera/bitshares-core that referenced this issue Jul 27, 2018
@nanomobile
CLI wallet: avoid directly overwriting wallet file on exit bitshares#…
3550961 
…1109
@cogutvalera cogutvalera mentioned this issue Jul 27, 2018
Merged
@abitmore
Copy link
Member Author

save_wallet_file.

cogutvalera pushed a commit to cogutvalera/bitshares-core that referenced this issue Jul 28, 2018
@nanomobile @cogutvalera
CLI wallet: avoid directly overwriting wallet file on exit bitshares#…
3b7fd97 
…1109
cogutvalera pushed a commit to cogutvalera/bitshares-core that referenced this issue Jul 30, 2018
@nanomobile @cogutvalera
CLI wallet: avoid directly overwriting wallet file on exit bitshares#…
a9e4d89 
…1109
cogutvalera pushed a commit to cogutvalera/bitshares-core that referenced this issue Jul 30, 2018
@nanomobile @cogutvalera
CLI wallet: avoid directly overwriting wallet file on exit bitshares#…
d61c5c2 
…1109
@cogutvalera
Copy link
Member

cogutvalera commented Jul 30, 2018 •
edited
Loading

my approximation/estimation is about 3 hours for this issue

@cogutvalera
Copy link
Member

Thanks !

cogutvalera pushed a commit to cogutvalera/bitshares-core that referenced this issue Jul 31, 2018
@nanomobile @cogutvalera
CLI wallet: avoid directly overwriting wallet file on exit bitshares#…
313cafc 
…1109
@cogutvalera
Copy link
Member

rebased already

@ryanRfox
Copy link
Contributor

Assigned to @cogutvalera and added estimate for 3 hours.

@cogutvalera
Copy link
Member

Thanks !

abitmore added a commit that referenced this issue Aug 17, 2018
@abitmore
Merge pull request #1195 from cogutvalera/valera_issue_1109
880a00a 
CLI wallet: avoid directly overwriting wallet file on exit #1109
@abitmore
Copy link
Member Author

Fixed by #1195.

@TheTaconator TheTaconator mentioned this issue Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cogutvalera cogutvalera

Labels
1a Epic High level concept to be addressed. Description should contain a list referencing child User Stories 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 CLI Impact flag identifying the command line interface (CLI) wallet application 6 Security Impact flag identifying system/user security 9c Large Effort estimation indicating TBD
Projects
None yet
Milestone
201810 - Feature Release
Development

No branches or pull requests
3 participants
@abitmore @ryanRfox @cogutvalera