Merge pull request #1250 from cwyyprog/develop

clean old style codes
bitshares · Aug 16, 2018 · 559db7b · 559db7b
2 parents 8df9e06 + 14e6cee
commit 559db7b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/libraries/chain/protocol/fee_schedule.cpp b/libraries/chain/protocol/fee_schedule.cpp
@@ -88,7 +88,7 @@ namespace graphene { namespace chain {
       {
          try {
             return op.calculate_fee( param.get<OpType>() ).value;
-         } catch (fc::assert_exception e) {
+         } catch (fc::assert_exception& e) {
              fee_parameters params; params.set_which(current_op);
              auto itr = param.parameters.find(params);
              if( itr != param.parameters.end() ) params = *itr;

diff --git a/libraries/db/include/graphene/db/generic_index.hpp b/libraries/db/include/graphene/db/generic_index.hpp
@@ -73,7 +73,7 @@ namespace graphene { namespace chain {
                                        [&m, &exc](ObjectType& o) mutable {
                                           try {
                                              m(o);
-                                          } catch (fc::exception e) {
+                                          } catch (fc::exception& e) {
                                              exc = std::current_exception();
                                              elog("Exception while modifying object: ${e} -- object may be corrupted",
                                                   ("e", e));

diff --git a/libraries/plugins/market_history/market_history_plugin.cpp b/libraries/plugins/market_history/market_history_plugin.cpp
@@ -247,12 +247,12 @@ struct operation_process_fill_order
              db.modify( *bucket_itr, [&]( bucket_object& b ){
                   try {
                      b.base_volume += trade_price.base.amount;
-                  } catch( fc::overflow_exception ) {
+                  } catch( fc::overflow_exception& ) {
                      b.base_volume = std::numeric_limits<int64_t>::max();
                   }
                   try {
                      b.quote_volume += trade_price.quote.amount;
-                  } catch( fc::overflow_exception ) {
+                  } catch( fc::overflow_exception& ) {
                      b.quote_volume = std::numeric_limits<int64_t>::max();
                   }
                   b.close_base = fill_price.base.amount;