Initial CMake support #220
Conversation
niclimcy
commented
Mar 25, 2023
niclimcy
commented
- For initial win32 support
- Change pythonInterface file extension to cpp because it is C++
- Requires external dependency pthread-win32 for Windows builds
Add missing imports to adam
[FIX] passing of sparse in StableEmbedding
Remove unused imports, fix NotImplementedError
Add a CPU-only build option
Add `device` and `dtype` parameters to `StableEmbedding`
Import missing warn function
improve install instructions
Add cuda12x to the list of targets
Fix for python 3.7
Update compile_from_source.md to mention cuda12x target
- For initial win32 support - Change pythonInterface file extension to cpp because it is C++ - Requires external dependency pthread-win32 for Windows builds
|
Consider changing phthread into canonical std::thread. There's also some scary malloc going on in that code, maybe take the opportunity to use the c++ primitives? EDIT: I merged your branch into the portability PR I opened, and I added the above, like this If you check #257, I added cpuonly build and CUDA detection. This way we could support building all targets from cmake. I also updated the output paths to match the old makefile. |
Those were seperate attempts, I think you should choose the PR that is the most complete (definitely not mine). |
