Edenzzzz's fix for min_8bit_size functionality in Optimizer base classes #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Optimizer tests are all green, despite the usual flakiness, but checked those cases one-by-one: everything fine. cc @matthewdouglas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes and closes #1181.
I couldn't push to Edenzzzz's branch as he used the
mainbranch and that had branch protection rules applied. So I couldn't continue in that PR as we need to release by the end of the day and want to include this valuable change.Thanks @Edenzzzz for providing this fix, I just had to apply the same to the other optimizer base class.