Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "lamb" to str2optimizer32bit #1222

Merged
merged 4 commits into from
May 30, 2024

Conversation

IndigoDosSantos
Copy link
Contributor

LAMB was missing in str2optimizer32bit.

@matthewdouglas
Copy link
Member

LGTM! I see the same issue exists for LARS too.

@IndigoDosSantos
Copy link
Contributor Author

LGTM! I see the same issue exists for LARS too.

Had a look again at bitsandbytes/optim and it appears it's not just LARS but many other optimizer variants as well.

@skku-daniilkim
Copy link

skku-daniilkim commented May 30, 2024

Hello! Is there currently any workaround for this issue, while this is being reviewed?

@Titus-von-Koeller
Copy link
Collaborator

@EtienneDosSantos, really good catch and ready to merge. Thank you! There're still some peculiarities with this code base that have gone unnoticed and still a bunch of cleaning up to do.

It so helpful if attentive members from the community take a hand-on approach like you and help us improve things. Super grateful for that!

Always happy to get future contributions from you as well :) Don't hesitate to tag me personally if you need input on anything or something catches your attention that is high impact and shouldn't be overlooked.

Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Titus-von-Koeller
Copy link
Collaborator

@skku-daniilkim I'll do a patch release in the next days, hopefully by early next week at latest.

For now you can see where BNB is installed and manually edit the files in the same way that you see in the diff of this PR. To find the install location you can do this:

In [1]: import inspect

In [2]: import bitsandbytes

In [3]: pkg_location = inspect.getfile(bitsandbytes)

In [4]: print(pkg_location)
/opt/conda/envs/bnb/lib/python3.8/site-packages/__init__.py

Then find the right file in the package directory structure of course.

@Titus-von-Koeller Titus-von-Koeller merged commit 1f2ca43 into bitsandbytes-foundation:main May 30, 2024
19 checks passed
Titus-von-Koeller pushed a commit that referenced this pull request Jun 5, 2024
* Revert "Add `"lamb"` to `str2optimizer32bit`"

* Update bitsandbytes/functional.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants