-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "lamb"
to str2optimizer32bit
#1222
Add "lamb"
to str2optimizer32bit
#1222
Conversation
LGTM! I see the same issue exists for LARS too. |
Had a look again at |
Hello! Is there currently any workaround for this issue, while this is being reviewed? |
@EtienneDosSantos, really good catch and ready to merge. Thank you! There're still some peculiarities with this code base that have gone unnoticed and still a bunch of cleaning up to do. It so helpful if attentive members from the community take a hand-on approach like you and help us improve things. Super grateful for that! Always happy to get future contributions from you as well :) Don't hesitate to tag me personally if you need input on anything or something catches your attention that is high impact and shouldn't be overlooked. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@skku-daniilkim I'll do a patch release in the next days, hopefully by early next week at latest. For now you can see where BNB is installed and manually edit the files in the same way that you see in the diff of this PR. To find the install location you can do this:
Then find the right file in the package directory structure of course. |
1f2ca43
into
bitsandbytes-foundation:main
* Revert "Add `"lamb"` to `str2optimizer32bit`" * Update bitsandbytes/functional.py
LAMB was missing in
str2optimizer32bit
.