-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal macos support #1018
minimal macos support #1018
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
fixed conflicts, rebased. |
@akx Would you be able to review, pls? |
now, only left |
Ah, I thought #996 solved it but it was the wrong main.py. Yes, this is needed |
Ok, I merged 949 now. Is this one obsolete then and can be closed? Why were these split out then? To make them atomic and easier to review for us? I like this approach a lot generally, but then it would be good to have a statement about it in the description and if you have some insight (even best guess) about dependencies between PRs, please make them explicit. The more actionable something is, the better. Also, reviewing and approving each other's PRs is also very helpful as an extra pair of eyes and other set of expertise gives more certainty in moving forward. Generally, @akx PRs for example were structured very well and the descriptions he gives were also very helpful: Context, atomic problem, solution. This makes it easy to review. If it's urgent to move forward and blocking it's also important to know. Anyways, again, we're super happy about this surge in community contributions and will be very focused in supporting and enabling you. One thing that would really help is to all work together to keep all info up to date in the respective RFC, so we have an overview of status, decisions and points that need further discussion. I ll then integrate the info from your comments into the top-most post to keep the overview up to date. Also, keeping track of PRs and intended merge order there might make sense. Please let us know how you think we should best move forward and we'll figure it out. I'll be back on Monday. Feel free to contact @younesbelkada if it's more urgent than that. |
Sry, closing was by accident. |
@Titus-von-Koeller // As I personally consider the integrity of the main branch is the most important.
And the recent series of merges were unexpected after months of delays. I wonder if you're putting too much faith in the reviewer 😋, and I do not give hasty reviews without thoroughly checking it myself. Anyway, Thank you for your attention, even during your vacation! |
Please see #1038 |
This is a PR to support macos based on @rickardp's work (PR #949 )
for those who want to use bitsandbytes under OSX with minimal support.
macos cpu module supportlibbitsandbytes_cpu.dylib
correctly.