Fix config normalise #987
Merged
Fix config normalise #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
commented
Jul 30, 2024
| @@ -655,7 +716,7 @@ func validateWorkflows(config *BitriseDataModel) ([]string, error) { | |||
| } | |||
|
|
|||
| // TODO: Why is this assignment needed? | |||
| stepListItem[stepID] = step | |||
| stepListItem[stepID] = *step | |||
There was a problem hiding this comment.
Here we reassigned the step with a pointer type, that's why we had to handle both pointer and value type steps here: https://github.com/bitrise-io/bitrise/pull/987/files#diff-1bb32c53b12166a3a66db70cbe1be4356cbc8adac0b84d14887022d830f8594aL1319
tothszabi
previously approved these changes
Jul 30, 2024
tothszabi
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
This PR fixes the bitrise config normalization. Normalization converts maps with interface{} keys to string-keyed maps, to make the config JSON compatible.