Kubebuilder pvc cleanup

.drone.yml

@@ -3,142 +3,17 @@ workspace:
   path: src/github.com/presslabs/mysql-operator
 
 pipeline:
-  build:
-    image: golang:1.9
-    environment:
-      - APP_VERSION=${DRONE_BRANCH/master/latest}
+  dependencies:
+    image: golang:1.11
     commands:
-      - make full-test
-      - make build
-      - make install-docker
-    when:
-      event: push
+      - make dependencies
 
-  build:
-    image: golang:1.9
-    environment:
-      - APP_VERSION=${DRONE_TAG}
+  lint:
+    image: golang:1.11
     commands:
-      - make full-test
-      - make build
-      - make install-docker
-    when:
-      event: tag
+      - make lint
 
-  publish-operator:
-    group: publish
-    image: plugins/docker
-    registry: quay.io
-    repo: quay.io/presslabs/mysql-operator
-    username: presslabs+drone
-    dockerfile: hack/docker/mysql-operator/Dockerfile
-    context: hack/docker/mysql-operator
-    tags: ["${DRONE_BRANCH/master/latest}"]
-    secrets:
-      - source: QUAY_TOKEN
-        target: DOCKER_PASSWORD
-    when:
-      event: push
-
-  publish-operator:
-    group: publish
-    image: plugins/docker
-    registry: quay.io
-    repo: quay.io/presslabs/mysql-operator
-    username: presslabs+drone
-    dockerfile: hack/docker/mysql-operator/Dockerfile
-    context: hack/docker/mysql-operator
-    tags: ["${DRONE_TAG}"]
-    secrets:
-      - source: QUAY_TOKEN
-        target: DOCKER_PASSWORD
-    when:
-      event: tag
-
-  publish-helper:
-    group: publish
-    image: plugins/docker
-    registry: quay.io
-    repo: quay.io/presslabs/mysql-helper
-    username: presslabs+drone
-    dockerfile: hack/docker/mysql-helper/Dockerfile
-    context: hack/docker/mysql-helper
-    tags: ["${DRONE_BRANCH/master/latest}"]
-    secrets:
-      - source: QUAY_TOKEN
-        target: DOCKER_PASSWORD
-    when:
-      event: push
-
-  publish-helper:
-    group: publish
-    image: plugins/docker
-    registry: quay.io
-    repo: quay.io/presslabs/mysql-helper
-    username: presslabs+drone
-    dockerfile: hack/docker/mysql-helper/Dockerfile
-    context: hack/docker/mysql-helper
-    tags: ["${DRONE_TAG}"]
-    secrets:
-      - source: QUAY_TOKEN
-        target: DOCKER_PASSWORD
-    when:
-      event: tag
-
-  publish-helm-chart:
-    group: publish
-    image: quay.io/presslabs/kluster-toolbox
-    pull: true
-    environment:
-      - GH_USER=presslabs-bot
+  test:
+    image: golang:1.11
     commands:
-      - cd hack/charts
-      - (cd mysql-operator && helm dep build)
-      - helm package mysql-operator
-      - CHART="$(basename *.tgz)" ; MESSAGE="Publish $(basename $CHART .tgz)"
-      - /usr/local/bin/gh put --skip-existing -m "$MESSAGE" "$CHART" "presslabs/charts/docs/"
-    secrets:
-      - GH_PASSWORD
-    when:
-      branch: master
-      event: push
-
-  # publish-mysql-helper:
-  #   group: publish
-  #   image: plugins/docker
-  #   mirror: https://mirror.gcr.io
-  #   registry: gcr.io
-  #   repo: gcr.io/pl-infra/mysql-helper
-  #   dockerfile: hack/docker/mysql-helper/Dockerfile
-  #   username: _json_key
-  #   tags: ["${DRONE_BRANCH/master/latest}", "${DRONE_COMMIT_SHA:0:7}"]
-  #   force_tag: true
-  #   build_args:
-  #     - release="${DRONE_COMMIT_SHA:0:7}"
-  #   secrets:
-  #     - source: GOOGLE_CREDENTIALS
-  #       target: DOCKER_PASSWORD
-  #   when:
-  #     event: push
-
-#  e2e-tests:
-#    image: gcr.io/pl-infra/kluster-mysql-helper:latest
-#    pull: true
-#    secrets:
-#      - GOOGLE_CREDENTIALS
-#      - GOOGLE_PROJECT_ID
-#      - TITANIUM_TEST_GS_CREDENTIALS
-#    environment:
-#      - TITANIUM_IMAGE_TAG=${DRONE_COMMIT_SHA:0:7}
-#      - OPERATOR_IMAGE=gcr.io/pl-infra/mysql-operator:${DRONE_COMMIT_SHA:0:7}
-#      - KUBECONFIG=/go/.kube/config
-#    commands:
-#      - sleep 1
-#
-#services:
-#  minikube:
-#    image: gcr.io/pl-infra/drone-minikube:v1.9.0
-#    privileged: true
-#    secrets:
-#      - GOOGLE_CREDENTIALS
-
+      - make test

.gitignore

@@ -24,6 +24,7 @@ nosetests.xml
 coverage.xml
 *.cover
 .hypothesis/
+cover.out
 
 # Translations
 *.mo
@@ -40,7 +41,7 @@ docs/_build/
 
 # ignore bin
 bin/
-hack/docker/mysql-helper/mysql-helper
+hack/docker/mysql-operator-sidecar/mysql-operator-sidecar
 hack/docker/mysql-operator/mysql-operator
 **/charts/*.tgz
 

.golangci.yaml

@@ -0,0 +1,37 @@
+run:
+  skip-dirs:
+    - vendor
+
+linters-settings:
+  dupl:
+    threshold: 400
+  gocyclo:
+    min-complexity: 10
+  govet:
+    check-shadowing: true
+  lll:
+    line-length: 170
+    tab-width: 4
+  gofmt:
+    simplify: false
+
+linters:
+  presets:
+    - bugs
+    - unused
+    - format
+    - style
+    - complexity
+    - performance
+
+  # we should re-enable them and make lint pass
+  disable:
+    - goimports
+    - maligned
+
+issues:
+  max-same-issues: 0
+  exclude-use-default: false
+  exclude:
+    # gosec G104, about unhandled errors. We do that with errcheck already
+    - "G104: Errors unhandled"

Dockerfile

@@ -0,0 +1,17 @@
+# Build the manager binary
+FROM golang:1.10.3 as builder
+
+# Copy in the go src
+WORKDIR /go/src/github.com/presslabs/mysql-operator
+COPY pkg/    pkg/
+COPY cmd/    cmd/
+COPY vendor/ vendor/
+
+# Build
+RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager github.com/presslabs/mysql-operator/cmd/manager
+
+# Copy the controller-manager into a thin image
+FROM ubuntu:latest
+WORKDIR /root/
+COPY --from=builder /go/src/github.com/presslabs/mysql-operator/manager .
+ENTRYPOINT ["./manager"]