Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address: include options to trim transaction results #488

Merged
merged 4 commits into from
Jul 20, 2016

Conversation

braydonf
Copy link
Contributor

@braydonf braydonf commented Jul 20, 2016

Query options to reduce the size of transactions to 1/3rd of the original size in many cases.

/insight-api/addrs/txs?from=0&to=50&noAsm=1&noSpent=1&noScriptSig=1

@matiu
Copy link
Contributor

matiu commented Jul 20, 2016

Looking good!

JIC, These are the all the fields that are not used for BWS Transaction History:

response.totalItems
response.from
response.to

from each response.item, only these fields are used:

  item.vin[].addr
  item.vin[].valueSat
  item.vout[].scriptPubKey
  item.vout[].scriptPubKey.addresses[]
  item.vout[].value
  item.blocktime
  item.firstSeen
  item.txid
  item.confirmations
  item.fees

See https://github.com/bitpay/bitcore-wallet-service/blob/master/lib/server.js#L2587

@braydonf braydonf changed the title WIP address: include options to trim transaction results address: include options to trim transaction results Jul 20, 2016
@matiu
Copy link
Contributor

matiu commented Jul 20, 2016

ACK, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants