Switch to "WARNING" logging level by default #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foresight Summary
View More Details✅ CI workflow has finished in 43 seconds and finished at 8th Feb, 2023.
*You can configure Foresight comments in your organization settings page. |
|
Straight forward, looks good to me I feel like we remove the newline for |
PhillypHenning
approved these changes
Feb 7, 2023
mickmcgrath13
approved these changes
Feb 7, 2023
arm4b
force-pushed
the
enh/default-logging-level
branch
from
3b47875
to
8079c3a
Compare
|
YES the output is WAY too noisy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the default logging level to
WARNINGinstead ofDEBUGfor BitOps.As we're starting to show the BitOps to others, be mindful of what data we show as logs, - users should be getting only the important messages, excluding all the noise.
Somewhat relevant to #270, which highlights a bigger problem with the log formatting standards.